NFC: Resolve some Sendable-related warnings
#7822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assorted fixes for sendability warnings
MaxDesiatov
added
concurrency
no functional change
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
xedin
approved these changes
Jul 27, 2024
| @@ -391,6 +392,7 @@ fileprivate struct Worker { | |||
| return self.semaphore.wait(timeout: deadline) | |||
| } | |||
|
|
|||
| @Sendable | |||
There was a problem hiding this comment.
I wonder if we should try enabling InferSendableFromCaptures instead of these explicit attributes in few places including properties.
There was a problem hiding this comment.
cc @MaxDesiatov, we can do that without experimental flags too.
There was a problem hiding this comment.
How would you do that without experimental flags? Does Swift 6 language mode include support for that?
There was a problem hiding this comment.
It’s an upcoming feature flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted fixes for sendability warnings.