NFC: Add AsyncStream-based API to AsyncProcess
#7830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
concurrency
needs tests
|
@swift-ci test |
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
added
no functional change
MaxDesiatov
changed the title
AsyncStream-based API to AsyncProcessAsyncStream-based API to AsyncProcess
|
@swift-ci test windows |
AndrewHoos
approved these changes
Aug 2, 2024
|
@swift-ci please test |
xedin
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing
AsyncProcessclosure-based API forstdoutandstderrconsumption requires a lot of tedious and error-prone ceremony for use ofasync. One needs to manually createAsyncStreams and their continuations, feed the output via the continuations, spawn a task group and consume the output in separate tasks, while launching the process at the same time.We should provide a simpler
popen-like API that allows passingasyncclosures that receive ready for iterationAsyncStreams as arguments.No functional change is made in this PR, the new API is not used yet outside of corresponding tests.