NFC: Rename PinsStore to PackageResolvedStore
#7839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
changed the title
PinsStore to PackageResolvedStorePinsStore to PackageResolvedStore
MaxDesiatov
added
no functional change
|
@swift-ci test |
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
xedin
approved these changes
Aug 2, 2024
…o maxd/rename-pins # Conflicts: # Sources/Workspace/Workspace+Dependencies.swift # Sources/Workspace/Workspace+Registry.swift # Sources/Workspace/Workspace+SourceControl.swift # Tests/PackageGraphTests/PubgrubTests.swift # Tests/WorkspaceTests/WorkspaceTests.swift
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Implemented
Package.resolvedfeature is called "pins", which can be confusing for SwiftPM contributors.Modifications:
Renamed uses of
pinsin types and functions to useResolvedPackagesStore,packageResolved, orresolutioninstead, depending on the exact context of use.Result:
It is easier for contributors to find relevant code.