Skip to content

Add a comment to explain why we don't process code coverage on test fail #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Aug 1, 2024

In #6894, code coverage processing was disabled because it produces spurious output. This PR just adds a comment to the current source that links back to that one for future reference.

@grynspan grynspan added the swift test Changes impacting `swift test` tool label Aug 1, 2024
@grynspan grynspan self-assigned this Aug 1, 2024
@grynspan
Copy link
Contributor Author

grynspan commented Aug 1, 2024

@swift-ci please test

…ail.

In #6894, code coverage processing was disabled because it produces spurious
output. This PR just adds a comment to the current source that links back to
that one for future reference.
@grynspan grynspan force-pushed the jgrynspan/explain-why-code-cov-is-missing-on-failure branch from dd2309d to e043eb6 Compare August 1, 2024 13:53
@grynspan
Copy link
Contributor Author

grynspan commented Aug 1, 2024

@swift-ci please test

@grynspan
Copy link
Contributor Author

grynspan commented Aug 1, 2024

@swift-ci please test Windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@grynspan grynspan enabled auto-merge (squash) August 1, 2024 13:53
@grynspan grynspan merged commit b24cc8b into main Aug 1, 2024
5 checks passed
@grynspan grynspan deleted the jgrynspan/explain-why-code-cov-is-missing-on-failure branch August 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation swift test Changes impacting `swift test` tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants