Remove temp_await from Snippets
#7848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
AndrewHoos
force-pushed
the
deprecateTempAwait4
branch
from
4ea9d85 to
d0c5ae1
Compare
AndrewHoos
force-pushed
the
deprecateTempAwait4
branch
from
d0c5ae1 to
86293ca
Compare
MaxDesiatov
changed the title
temp_await [part 4]temp_await from Snippets
|
@swift-ci test |
AndrewHoos
force-pushed
the
deprecateTempAwait4
branch
from
86293ca to
5e3a05f
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove temp_await from Snippets
Motivation:
temp_await is unsafe and it would be better to use true async methods
Modifications:
Remove usages of temp_await from Snippets
Result:
Safer more modern Swift code