[Build] BuildPlan: Always discover test modules through their aggrega… #7879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
owenv
as code owners
|
@swift-ci please test |
…te products Fixes a situation when tests were build for both host and target even though they should have been built only for the host (i.e. when one of the modules depends on a macro).
xedin
force-pushed
the
too-many-test-modules-too-little-time
branch
from
f2e7318 to
7c2ef8b
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Aug 15, 2024
swiftlang#7879) …te products ### Motivation: Fixes a situation when tests were build for both host and target even though they should have been built only for the host (i.e. when one of the modules depends on a macro). ### Modifications: - Adjusted `BuildPlan.computeDestinations` to never add `test` modules to successor list of a package and allow `test` products to always iterate their module dependencies instead. ### Result: If one of the test targets depends on a macro we'd never attempt to build others for "target".
xedin
added a commit
to swiftlang/swift-foundation
that referenced
this pull request
Aug 15, 2024
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
xedin
added a commit
to swiftlang/swift-foundation
that referenced
this pull request
Aug 15, 2024
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
jmschonfeld
pushed a commit
to swiftlang/swift-foundation
that referenced
this pull request
Aug 15, 2024
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
xedin
added a commit
to swiftlang/swift-foundation
that referenced
this pull request
Aug 27, 2024
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix. (cherry picked from commit d14ceaf)
xedin
added a commit
to swiftlang/swift-foundation
that referenced
this pull request
Aug 28, 2024
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix. (cherry picked from commit d14ceaf)
jmschonfeld
pushed a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Sep 4, 2024
…ng#855) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
parkera
pushed a commit
to swiftlang/swift-foundation
that referenced
this pull request
Sep 5, 2024
…901) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix. Co-authored-by: Pavel Yaskevich <[email protected]>
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
…ng#855) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te products
Motivation:
Fixes a situation when tests were build for both host and target even though they should have been built only for the host (i.e. when one of the modules depends on a macro).
Modifications:
BuildPlan.computeDestinationsto never addtestmodules to successor list of a package and allowtestproducts to always iterate their module dependencies instead.Result:
If one of the test targets depends on a macro we'd never attempt to build others for "target".