Un-Revert "[Build] Free BuildPlan from BuildTriple"
#7883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cdac335.
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
MaxDesiatov
approved these changes
Aug 15, 2024
|
@swift-ci please test |
xedin
deleted the
revert-7882-revert-7877-no-more-buildTriple-use-in-build-plan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7882
The CI problem associated with this revert actually stems from swift-foundation hard-coding a path that is no longer valid because some tests in
FoundationEssentialsTeststest macros which means that xctest bundle is going to be built forhostand get-toolsuffix for its resources directory. Using non-prefixed directory was incorrect because it's not related to the bundle that would actually be run.