[SourceKitLSP] Start using SwiftPM independent BuildDestination typ…
#7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in `BuildTarget` API `BuildTriple` is going away to it's as good time as any to introduce a new type to be used by SourceKit-LSP.
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
xedin
added a commit
to xedin/sourcekit-lsp
that referenced
this pull request
Aug 15, 2024
`BuildTriple` is going away to it's as good time as any to introduce a new type to be used by SourceKit-LSP. Paired with swiftlang/swift-package-manager#7884
|
swiftlang/sourcekit-lsp#1627 |
xedin
added a commit
to xedin/sourcekit-lsp
that referenced
this pull request
Aug 15, 2024
`BuildTriple` is going away to it's as good time as any to introduce a new type to be used by SourceKit-LSP. Paired with swiftlang/swift-package-manager#7884
MaxDesiatov
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e in
BuildTargetAPIMotivation:
BuildTripleis going away to it's as good time as any to introduce a new type to be used by SourceKit-LSP.Modifications:
BuildDestinationAPI to be used by SourceKit-LSP instead ofBuildTripleBuildTripleuse fromBuildTargetResult:
BuildTripleis no longer used by SourceKit-LSP.