Skip to content

directoryURL is missing from the Target protocol in the PackagePlugin APIs #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

directoryURL is missing from the Target protocol in the PackagePlugin APIs #8002

merged 1 commit into from
Oct 1, 2024

Conversation

jakepetroules
Copy link
Contributor

The directoryURL property was added to all of the concrete Target implementations, such as SwiftSourceModuleTarget, ClangSourceModuleTarget, and so on, but not to the base protocol itself.

This means you need a bunch of conditional casts when trying to access the directoryURL in a package plugin.

Closes: #8001

@jakepetroules
directoryURL is missing from the Target protocol in the PackagePlugin…
f51903e 
… APIs

The directoryURL property was added to all of the concrete Target implementations, such as SwiftSourceModuleTarget, ClangSourceModuleTarget, and so on, but not to the base protocol itself.

This means you need a bunch of conditional casts when trying to access the directoryURL in a package plugin.

Closes: #8001
@jakepetroules
Copy link
Contributor Author

@swift-ci please test

@jakepetroules jakepetroules enabled auto-merge (rebase) September 27, 2024 18:52
bnbarham
bnbarham approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neonichu do you remember if there was any reason we didn't deprecate + add on the protocol, or did we just miss it?

@jakepetroules
Copy link
Contributor Author

@swift-ci please smoke test macOS

@jakepetroules
Copy link
Contributor Author

@swift-ci test failed

@bnbarham
Copy link
Contributor

@swift-ci please test macOS

@dschaefer2
Copy link
Member

The directoryURL property was added to all of the concrete Target implementations, such as SwiftSourceModuleTarget, ClangSourceModuleTarget, and so on, but not to the base protocol itself.

Whoops :). Thanks, Jake!

@neonichu
Copy link
Contributor

@neonichu do you remember if there was any reason we didn't deprecate + add on the protocol, or did we just miss it?

Don't remember anything specific, so I think I just missed it.

@jakepetroules jakepetroules merged commit d6d437a into main Oct 1, 2024
5 checks passed
@jakepetroules jakepetroules deleted the eng/PR-8001 branch October 1, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@dschaefer2 dschaefer2 dschaefer2 approved these changes

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

directoryURL is missing from the Target protocol in the PackagePlugin APIs
4 participants
@jakepetroules @bnbarham @dschaefer2 @neonichu