Ensure a newline is printed after Planning build #8050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a PackageStructure build needs to occur during a `swift test --skip-build` command there is no newline printed to the terminal, causing the first line of listed tests to appear on the same line as `[1/1] Planning Build`. This doesn't occur when you omit `--skip-build` because there is code in the `LLBuildProgressTracker.swift` that calls `progressAnimation.complete(success:)` when a build completes. Ideally I'd like to contain this logic t othe LLBuildProgressTracker, however for a PackageStructure build the relevant buildComplete delegate method is never called.
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca and
owenv
as code owners
jakepetroules
approved these changes
Oct 16, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PackageStructure build needs to occur during a
swift test list --skip-buildcommand there is no newline printed to the terminal, causing the first line of listed tests to appear on the same line as the progress, i.e:[1/1] Planning buildTestPackageTests.example()This doesn't occur when you omit
--skip-buildbecause there is code in theLLBuildProgressTracker.swiftthat callsprogressAnimation.complete(success:)when a build completes. Ideally I'd like to contain this logic to the LLBuildProgressTracker, however for a PackageStructure build the relevant buildComplete delegate method is never called.