completion-tool list-executables should list executable names
#8053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of names of executables Update the completion tool so it prints the list of executable names instead of target names. The executable products names determines the name fo the actual binary written to disk, which is what you'd want from a completion-tool. That patch also adds a few tests for completion-tool around this specific behaviour. There weren't existing tests for the completion-tool. More tests to follow in a subsequent PR focusing on testing this area specifically. Fixes swiftlang#8033
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca and
owenv
as code owners
plemarquand
changed the title
MaxDesiatov
reviewed
Oct 17, 2024
MaxDesiatov
changed the title
swift package completion-tool list-executables should list names of executables
MaxDesiatov
changed the title
swift package completion-tool list-executables should list names of executablesswift package completion-tool list-executables should list executable names
MaxDesiatov
changed the title
swift package completion-tool list-executables should list executable namescompletion-tool list-executables should list executable names
MaxDesiatov
reviewed
Oct 17, 2024
plemarquand
force-pushed
the
list-executables-products-not-targets
branch
from
3cdfd64 to
d380ff9
Compare
MaxDesiatov
approved these changes
Oct 17, 2024
MaxDesiatov
reviewed
Oct 17, 2024
Fixtures/Miscellaneous/DifferentProductTargetName/Package.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
lawyoum
added a commit
to lawyoum/swift-package-manager
that referenced
this pull request
Oct 22, 2024
…es (swiftlang#8053)" This reverts commit 5efd210.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the completion tool so it prints the list of executable names instead of target names. The executable products names determines the name fo the actual binary written to disk, which is what you'd want from a completion-tool.
That patch also adds a few tests for completion-tool around this specific behaviour. There weren't existing tests for the completion-tool. More tests to follow in a subsequent PR focusing on testing this area specifically.
Fixes #8033