Test: ensure swift-[build|test] emit expected number of fatal error on console #8076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
plemarquand
requested changes
Oct 25, 2024
|
Thanks for the contribution! A few comments, and I noticed the test fixture is missing. |
bkhouri
force-pushed
the
t/main/gh6605_add_test_fatal_error_occurs_onces_in_output
branch
from
2e93797 to
8cf6b88
Compare
bkhouri
commented
Oct 25, 2024
MaxDesiatov
reviewed
Oct 27, 2024
MaxDesiatov
reviewed
Oct 27, 2024
Comment on lines
121
to
123
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Formatting is off here, would you mind running the formatter on newly added files?
There was a problem hiding this comment.
I ran swift format format --in-place Tests/_InternalTestSupportTests/Misc.swift on the file.
There was a problem hiding this comment.
I still see stray whitespaces surrounding curly braces. Unfortunately, swift-format is not great at following our formatting style and lacks required customizations to specify it. We're using https://github.com/nicklockwood/SwiftFormat in SwiftPM instead.
There was a problem hiding this comment.
Also see "Creating Pull Requests" section here https://github.com/swiftlang/swift-package-manager/blob/main/CONTRIBUTING.md#creating-pull-requests
There was a problem hiding this comment.
formatting all touched file using https://github.com/nicklockwood/SwiftFormat resulted in many changes. so I only formatted this file.
bkhouri
force-pushed
the
t/main/gh6605_add_test_fatal_error_occurs_onces_in_output
branch
from
8cf6b88 to
d281225
Compare
plemarquand
approved these changes
Oct 29, 2024
bkhouri
force-pushed
the
t/main/gh6605_add_test_fatal_error_occurs_onces_in_output
branch
from
d281225 to
f972479
Compare
|
@swift-ci test |
|
@swift-ci test windows |
…n console Add an automated tests that ensures swift-build and swift-test emit the expected amount of `error: fatalError` message on the console output.
bkhouri
force-pushed
the
t/main/gh6605_add_test_fatal_error_occurs_onces_in_output
branch
from
f972479 to
8edd10e
Compare
|
@swift-ci test |
bkhouri
changed the title
|
The Swift Test Linux Platform build failure appears to be unrelated to my change |
|
@swift-ci please test Linux |
|
I believe swiftlang/swift#77309 was the underlying build issue and was merged about 6 hours ago. Can we re-trigger the failed build? |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
bkhouri
deleted the
t/main/gh6605_add_test_fatal_error_occurs_onces_in_output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an automated tests that ensures swift-build and swift-test emit the expected amount of
error: fatalErrormessage on the console output.Motivation:
Issue #6605 reported
error: fatalErrorwas emitted twice to the console output, and has since been fixed. We should ensure the issue does not regress.Modifications:
Add an automated tests that verifies
swift-builddoes not emit aerror: fatalErrorinstdoutorstderrwhen a building a test that does not compile.Result: