Use async HTTPClient in BinaryArtifactsManager
#8087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test linux |
plemarquand
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To adopt Swift concurrency in
ManifestLoader, we need to convertRegistryClientfirst, which then would require use ofHTTPClientinstead ofLegacyHTTPClient. That would also cascade toBinaryArtifactsManager, so I'm starting there first to make PRs smaller.Modifications:
Converted (and as a consequence, simplified) code in
Workspace+BinaryArtifacts.swift, also adoptedHTTPClientinWorkspaceTeststo fix tests after the change.Converted some error diagnostics to conform to
Error, which makes control flow withObservabilityScope.trapwrapper easier to write and read.Result:
One major previous adopter of
LegacyHTTPClientis now compatible with Swift concurrency.Since
BinaryArtifactsManagerwas blocking Swift concurrency thread pool and also used.sharedConcurrentdispatch queue, this potentially fixes thread explosion/deadlocks that may have been caused by previously broken code.