Add Package edit support for packages with unsafe flags #8120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi2gage
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
hi2gage
force-pushed
the
add_packaged_edit_support_for_unsafe
branch
from
752f1de to
4d0f8a7
Compare
hi2gage
force-pushed
the
add_packaged_edit_support_for_unsafe
branch
from
4d0f8a7 to
648734d
Compare
|
Awesome. That really annoyed me :). @swift-ci please test |
dschaefer2
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8079
Allows unsafe flags for edited packages
Motivation:
Edited packages in SwiftPM should be allowed to use unsafe flags.
Modifications:
Adjusted logic in
unsafeAllowedPackagesto add.editedpackages to the allowed list, alongside the root package and.fileSystempackagesResult:
After this change, edited packages will be permitted to use unsafe flags.