Unify env vars for Utilities/bootstrap commands
#8154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for enabling incremental builds when running `./Utillities/bootstrap build --release` and `./Utilities/bootstrap test --release` in a sequence.
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
dschaefer2
approved these changes
Dec 4, 2024
jakepetroules
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for enabling incremental builds when running
./Utillities/bootstrap build --releaseand./Utilities/bootstrap test --releasein a sequence.Motivation:
Environment variables passed to
swift-bootstrapfrom./Utilities/bootstrap buildand./Utilities/bootstrap testcommands unnecessarily differed slightly, which caused generated build manifests to be different. This precluded incremental builds when running these commands in a sequence one after each other, slowing down our CI jobs.Modifications:
Moved env var computation logic to the existing
get_swiftpm_env_cmdfunction inUtilities/bootstrap.Result:
swift-bootstrapis consistently called with the same environment variables, ensuring that generated build manifests can be the same, eventually enabling incremental builds.