Skip to content

[Traits] Remove experimental and SPI guards #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

FranzBusch
Copy link
Member

Motivation

Traits got oficially accepted https://forums.swift.org/t/accepted-with-modifications-se-0450-package-traits/76705 so we can remove the the SPI and experimental guards now.

Modification

This PR removes the SPI for traits, makes the availability 6.1, and removes the experimental prefix from all the arguments.

Result

Traits are becoming an official feature.

# Motivation

Traits got oficially accepted https://forums.swift.org/t/accepted-with-modifications-se-0450-package-traits/76705 so we can remove the the SPI and experimental guards now.

# Modification

This PR removes the SPI for traits, makes the availability 6.1, and removes the experimental prefix from all the arguments.

# Result

Traits are becoming an official feature.
@FranzBusch
Copy link
Member Author

@swift-ci please test

@FranzBusch
Copy link
Member Author

@swift-ci test windows

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still needs to be cherry-picked for 6.1 annotation to be valid.

@FranzBusch FranzBusch merged commit d77dad0 into swiftlang:main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants