Clean up warnings, fix handling of dep version changes #8232
Conversation
Assume dependent products from prebuilts are being used.
dschaefer2
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
| @@ -352,9 +358,11 @@ private func checkAllDependenciesAreUsed( | |||
| let usedByPackage = productDependencies.contains { $0.name == product.name } | |||
| // We check if any of the products of this dependency is guarded by a trait. | |||
| let traitGuarded = traitGuardedProductDependencies.contains(product.name) | |||
| // Consider prebuilts as used | |||
| let prebuilt = prebuilts[dependency.identity]?.keys.contains(product.name) ?? false | |||
|
|
|||
| // If the product is either used directly or guarded by a trait we consider it as used | |||
There was a problem hiding this comment.
Nit: this comment has to be updated as well.
There was a problem hiding this comment.
I just removed that comment. It's redundant.
That's what the change in PrebuiltsTest does. |
|
I'm going to lump this in with another bigger change coming to fix a serious bug. |
Found a bug where if you change swift syntax version in your manifest, we were not changing the use of prebuilts to match. This adds a scan to do so. Also requires that we add the version of the prebuilt to the workspace state.
dschaefer2
changed the title
|
I found a bug where if you change swift syntax version in your manifest, we were not changing the use of prebuilts to match. I have added a scan to do so. Also requires that we add the version of the prebuilt to the workspace state. |
dschaefer2
dismissed
xedin’s stale review
Code has changed a lot so needs a new review.
I found a bug where if you change swift syntax version in your manifest, we were not changing the use of prebuilts to match. I have added a scan to do so. Also requires that we add the version of the prebuilt to the workspace state. Assume dependent products from prebuilts are being used to remove the warning for swift-syntax.
Assume dependent products from prebuilts are being used.