Skip to content

Revert "Sever the package dependency if using SwiftBuild Framework" #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Revert "Sever the package dependency if using SwiftBuild Framework" #8437

merged 1 commit into from
Apr 2, 2025

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Apr 1, 2025

Reverts #8434

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 1, 2025

@swift-ci please test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 1, 2025

@swift-ci please test self hosted windows

@bkhouri bkhouri enabled auto-merge (squash) April 1, 2025 15:17
@bkhouri bkhouri marked this pull request as draft April 1, 2025 15:31
auto-merge was automatically disabled April 1, 2025 15:31

Pull request was converted to draft

@drodriguez
Copy link
Contributor

Why it went back to Draft? It should be merged. One cannot build main at the moment.

@bkhouri bkhouri marked this pull request as ready for review April 2, 2025 01:03
@bkhouri bkhouri merged commit e64232e into main Apr 2, 2025
6 checks passed
@bkhouri bkhouri deleted the revert-8434-t/main/sever_swift-support-core_dependency branch April 2, 2025 01:03
@bkhouri bkhouri mentioned this pull request Apr 2, 2025
Open
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 2, 2025

Why it went back to Draft? It should be merged. One cannot build main at the moment.

Out of curiosity, what error were you encountering?

@drodriguez
Copy link
Contributor

Building SwiftPM with swift build, using SWIFTPM_NO_SWBUILD_DEPENDENCY=1 and SWIFTCI_USE_LOCAL_DEPS=1

.../swiftpm/Sources/Basics/Archiver/TarArchiver.swift:15:15: error: no such module 'TSCBasic'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodriguez drodriguez drodriguez approved these changes

@bripeticca bripeticca bripeticca approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkhouri @drodriguez @bripeticca