Skip to content

[Tests] NFC: Add a package loading test for .defaultIsolation setting #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Tests] NFC: Add a package loading test for .defaultIsolation setting #8461

wants to merge 1 commit into from

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 8, 2025

Meant to be a part of #8301

@xedin
Copy link
Contributor Author

xedin commented Apr 8, 2025

@swift-ci please test

@bkhouri
Copy link
Contributor

bkhouri commented Apr 8, 2025

@swift-ci test self hosted windows

@xedin
Copy link
Contributor Author

xedin commented Apr 8, 2025

Hm. Self-hosted Windows fails with C:\Package.swift:10:18: error: type 'SwiftSetting' has no member 'defaultIsolation' even though the package description flag is set to '6.2.0' and there is definitely a defaultIsolation declared in SwiftSetting as @available(_PackageDescription, introduced: 6.2).

@xedin
Copy link
Contributor Author

xedin commented Apr 10, 2025

@swift-ci please test Windows

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Apr 12, 2025

@swift-ci please test Windows

@xedin
Copy link
Contributor Author

xedin commented Apr 14, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Apr 18, 2025

@swift-ci please test Windows self hosted

@xedin
Copy link
Contributor Author

xedin commented Apr 18, 2025

@swift-ci please test self hosted windows

@xedin xedin force-pushed the add-forgotten-test-for-defaultIsolation branch from f08159f to 0e3f3ad Compare April 18, 2025 07:29
@xedin
Copy link
Contributor Author

xedin commented Apr 18, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Apr 18, 2025

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Apr 20, 2025

@swift-ci please test self hosted Windows platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Apr 21, 2025

@swift-ci please test self hosted Windows platform

@xedin
Copy link
Contributor Author

xedin commented Apr 23, 2025

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkhouri bkhouri bkhouri approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @bkhouri