Skip to content

Enable more plugin related tests for non-macOS platforms #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 24, 2025
Merged

Enable more plugin related tests for non-macOS platforms #8477

merged 8 commits into from
Apr 24, 2025

Conversation

cmcgee1024
Copy link
Member

@cmcgee1024 cmcgee1024 commented Apr 10, 2025 •
edited
Loading

There are tests that were formerly failing due to missing support for plugins in the old PIF builder.
Enable these test for better coverage with the new builder.

  • Fix spelling in one of the APIs

  • Remove macOS-specific linker flag in the PIF builder and use a setting that is target platform neutral

  • Update skip comments for tests based on new analysis of the failures

@cmcgee1024 cmcgee1024 mentioned this pull request Apr 10, 2025
Open
1 task
@cmcgee1024
Copy link
Member Author

@swift-ci test Linux

@cmcgee1024
Copy link
Member Author

This does not work currently because of this error in swift-build: swiftlang/swift-build#395

@cmcgee1024 cmcgee1024 mentioned this pull request Apr 10, 2025
Open
1 task
@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Enable a plugin test for non-macOS
3fb0ef9 
Update skip message descriptions with latest failure details

Remove the switch for the swiftc linker driver
@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024 cmcgee1024 changed the title Switch to swiftc as the linker driver in SwiftBuildSupport Enable more plugin related tests for non-macOS platforms Apr 22, 2025
@cmcgee1024
Copy link
Member Author

@swift-ci please test macOS

@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Copy link
Member Author

@swift-ci please test

1 similar comment
@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Copy link
Member Author

@swift-ci test Windows

@cmcgee1024
Copy link
Member Author

@swift-ci please test

@cmcgee1024
Copy link
Member Author

@swift-ci test Windows

@cmcgee1024 cmcgee1024 marked this pull request as ready for review April 24, 2025 17:12
@cmcgee1024
Copy link
Member Author

@swift-ci test macOS

@cmcgee1024 cmcgee1024 enabled auto-merge (squash) April 24, 2025 22:13
@cmcgee1024 cmcgee1024 merged commit 5da13be into swiftlang:main Apr 24, 2025
6 checks passed
@MaxDesiatov
Copy link
Contributor

Reverting due to failures on Amazon Linux 2 https://ci.swift.org/job/oss-swift-package-amazon-linux-2/4177/console

MaxDesiatov added a commit that referenced this pull request Apr 25, 2025
@MaxDesiatov
Revert "Enable more plugin related tests for non-macOS platforms (#8477…
bd7cead 
…)"

This reverts commit 5da13be.
@MaxDesiatov MaxDesiatov mentioned this pull request Apr 25, 2025
Merged
MaxDesiatov added a commit that referenced this pull request Apr 25, 2025
@MaxDesiatov
Revert "Enable more plugin related tests for non-macOS platforms" (#8557
2b659da 
)

Reverts #8477 due to Amazon Linux 2 failures https://ci.swift.org/job/oss-swift-package-amazon-linux-2/4177/console
@MaxDesiatov
Copy link
Contributor 

Test Case 'PackageCommandSwiftBuildTests.testCommandPluginTestingCallbacks' started at 2025-04-25 05:55:25.365
<EXPR>:0: error: PackageCommandSwiftBuildTests.testCommandPluginTestingCallbacks : threw error "executionFailure(underlying: terminated(1): /home/build-user/build/buildbot_linux/swiftpm-linux-x86_64/x86_64-unknown-linux-gnu/release/swift-package-manager --package-path /tmp/spm-tests-testCommandPluginTestingCallbacks.vXVR4b/MyPackage --configuration debug --build-system swiftbuild my-test-tester output:
    error from the plugin host: unspecified("fatalError")
    Building for debugging...
    0%: Constructing description
    0%: Planning deferred tasks
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: working-directory unsupported on this platform
    error: Build failed, stdout: "error from the plugin host: unspecified(\"fatalError\")\n", stderr: "Building for debugging...\n0%: Constructing description\n0%: Planning deferred tasks\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: working-directory unsupported on this platform\nerror: Build failed\n")"
Test Case 'PackageCommandSwiftBuildTests.testCommandPluginTestingCallbacks' failed (2.873 seconds)
Test Suite 'PackageCommandSwiftBuildTests' failed at 2025-04-25 05:55:28.239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules left review comments

@dschaefer2 dschaefer2 dschaefer2 left review comments

@bkhouri bkhouri bkhouri approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmcgee1024 @MaxDesiatov @jakepetroules @bkhouri @dschaefer2