Skip to content

Fix Python3 issues and add type hints to run_sk_stress_test #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 28, 2022

@ahoppen ahoppen changed the title WIP: Fix Python3 issues and add type hints to run_sk_stress_test Fix Python3 issues and add type hints to run_sk_stress_test Jul 28, 2022
@ahoppen ahoppen merged commit 21cfa85 into swiftlang:main Jul 28, 2022
@justice-adams-apple
Copy link
Collaborator

My mistake for not catching this. Thank you for the quick PR 👍

Appreciate it!

If you need to reconfigure the stdout encoding in Python3 we can do so with
sys.stdout.reconfigure(encoding='YOUR_ENCODING')

But it should default to utf-8 so I think it's OK to leave out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants