common.py: update ArgumentParser to 1.2.0 #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version bump would benefit SwiftPM, Swift Driver, and SourceKit-LSP, which all use ArgumentParser.
MaxDesiatov
requested review from
shahmishal,
clackary and
justice-adams-apple
as code owners
|
@swift-ci test |
MaxDesiatov
changed the title
|
@swift-ci test |
justice-adams-apple
approved these changes
Nov 14, 2022
|
I wonder if this needs to be reverted now that it's merged? I should've marked it as draft, sorry. None of the version bumps in corresponding repositories have been merged yet. |
shahmishal
added a commit
that referenced
this pull request
Nov 15, 2022
This reverts commit a952e56.
|
Yes, we should revert it. |
MaxDesiatov
added a commit
to MaxDesiatov/swift-source-compat-suite
that referenced
this pull request
Nov 15, 2022
This reverts commit a952e56.
|
Revert submitted in #741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version bump would benefit SwiftPM, Swift Driver, and SourceKit-LSP, which all use ArgumentParser.