Skip to content

Rename genericParameters to genericParameterClause for consistency. #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CodeGeneration/Sources/SyntaxSupport/DeclNodes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ public let DECL_NODES: [Node] = [
description: "Declares the name of this enum. If the name matches a reserved keyword use backticks to escape it."
),
Child(
name: "GenericParameters",
name: "GenericParameterClause",
kind: .node(kind: "GenericParameterClause"),
nameForDiagnostics: "generic parameter clause",
description: "The generic parameters, if any, for this enum declaration.",
Expand Down
2 changes: 1 addition & 1 deletion CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public let TYPE_NODES: [Node] = [
kind: "Type",
children: [
Child(
name: "GenericParameters",
name: "GenericParameterClause",
kind: .node(kind: "GenericParameterClause")
),
Child(
Expand Down
2 changes: 1 addition & 1 deletion Sources/SwiftParser/Nominals.swift
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ extension RawEnumDeclSyntax: NominalTypeDeclarationTrait {
enumKeyword: introducerKeyword,
unexpectedBeforeIdentifier,
identifier: identifier,
genericParameters: primaryOrGenerics,
genericParameterClause: primaryOrGenerics,
inheritanceClause: inheritanceClause,
genericWhereClause: genericWhereClause,
memberBlock: memberBlock,
Expand Down
2 changes: 1 addition & 1 deletion Sources/SwiftParser/Types.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ extension Parser {
let baseType = self.parseType()
return RawTypeSyntax(
RawNamedOpaqueReturnTypeSyntax(
genericParameters: generics,
genericParameterClause: generics,
baseType: baseType,
arena: self.arena
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private func childNameForDiagnostics(_ keyPath: AnyKeyPath) -> String? {
return "attributes"
case \EnumDeclSyntax.modifiers:
return "modifiers"
case \EnumDeclSyntax.genericParameters:
case \EnumDeclSyntax.genericParameterClause:
return "generic parameter clause"
case \EnumDeclSyntax.inheritanceClause:
return "inheritance clause"
Expand Down
88 changes: 88 additions & 0 deletions Sources/SwiftSyntax/SwiftSyntaxCompatibility.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,91 @@ public typealias AccessPathComponentSyntax = ImportPathComponentSyntax

@available(*, deprecated, renamed: "WithAttributesSyntax")
public typealias AttributedSyntax = WithAttributesSyntax

public extension EnumDeclSyntax {
@available(*, deprecated, renamed: "unexpectedBetweenIdentifierAndGenericParameterClause")
var unexpectedBetweenIdentifierAndGenericParameters: UnexpectedNodesSyntax? { unexpectedBetweenIdentifierAndGenericParameterClause }

@available(*, deprecated, renamed: "genericParameterClause")
var genericParameters: GenericParameterClauseSyntax? { genericParameterClause }

@available(*, deprecated, renamed: "unexpectedBetweenGenericParameterClauseAndInheritanceClause")
var unexpectedBetweenGenericParametersAndInheritanceClause: UnexpectedNodesSyntax? { unexpectedBetweenGenericParameterClauseAndInheritanceClause }

@available(*, deprecated, message: "Use an initializer with a genericParameterClause argument.")
init(
leadingTrivia: Trivia? = nil,
_ unexpectedBeforeAttributes: UnexpectedNodesSyntax? = nil,
attributes: AttributeListSyntax? = nil,
_ unexpectedBetweenAttributesAndModifiers: UnexpectedNodesSyntax? = nil,
modifiers: ModifierListSyntax? = nil,
_ unexpectedBetweenModifiersAndEnumKeyword: UnexpectedNodesSyntax? = nil,
enumKeyword: TokenSyntax = .keyword(.enum),
_ unexpectedBetweenEnumKeywordAndIdentifier: UnexpectedNodesSyntax? = nil,
identifier: TokenSyntax,
_ unexpectedBetweenIdentifierAndGenericParameters: UnexpectedNodesSyntax? = nil,
genericParameters: GenericParameterClauseSyntax? = nil,
_ unexpectedBetweenGenericParametersAndInheritanceClause: UnexpectedNodesSyntax? = nil,
inheritanceClause: TypeInheritanceClauseSyntax? = nil,
_ unexpectedBetweenInheritanceClauseAndGenericWhereClause: UnexpectedNodesSyntax? = nil,
genericWhereClause: GenericWhereClauseSyntax? = nil,
_ unexpectedBetweenGenericWhereClauseAndMemberBlock: UnexpectedNodesSyntax? = nil,
memberBlock: MemberDeclBlockSyntax,
_ unexpectedAfterMemberBlock: UnexpectedNodesSyntax? = nil,
trailingTrivia: Trivia? = nil
) {
self.init(
leadingTrivia: leadingTrivia,
unexpectedBeforeAttributes,
attributes: attributes,
unexpectedBetweenAttributesAndModifiers,
modifiers: modifiers,
unexpectedBetweenModifiersAndEnumKeyword,
enumKeyword: enumKeyword,
unexpectedBetweenEnumKeywordAndIdentifier,
identifier: identifier,
unexpectedBetweenIdentifierAndGenericParameters,
genericParameterClause: genericParameters,
unexpectedBetweenGenericParametersAndInheritanceClause,
inheritanceClause: inheritanceClause,
unexpectedBetweenInheritanceClauseAndGenericWhereClause,
genericWhereClause: genericWhereClause,
unexpectedBetweenGenericWhereClauseAndMemberBlock,
memberBlock: memberBlock,
unexpectedAfterMemberBlock,
trailingTrivia: trailingTrivia
)
}
}

public extension NamedOpaqueReturnTypeSyntax {
@available(*, deprecated, renamed: "unexpectedBeforeGenericParameterClause")
var unexpectedBeforeGenericParameters: UnexpectedNodesSyntax? { unexpectedBeforeGenericParameterClause }

@available(*, deprecated, renamed: "genericParameterClause")
var genericParameters: GenericParameterClauseSyntax? { genericParameterClause }

@available(*, deprecated, renamed: "unexpectedBetweenGenericParameterClauseAndBaseType")
var unexpectedBetweenGenericParametersAndBaseType: UnexpectedNodesSyntax? { unexpectedBetweenGenericParameterClauseAndBaseType }

@available(*, deprecated, message: "Use an initializer with a genericParameterClause argument.")
init(
leadingTrivia: Trivia? = nil,
_ unexpectedBeforeGenericParameters: UnexpectedNodesSyntax? = nil,
genericParameters: GenericParameterClauseSyntax,
_ unexpectedBetweenGenericParametersAndBaseType: UnexpectedNodesSyntax? = nil,
baseType: some TypeSyntaxProtocol,
_ unexpectedAfterBaseType: UnexpectedNodesSyntax? = nil,
trailingTrivia: Trivia? = nil
) {
self.init(
leadingTrivia: leadingTrivia,
unexpectedBeforeGenericParameters,
genericParameterClause: genericParameters,
unexpectedBetweenGenericParametersAndBaseType,
baseType: baseType,
unexpectedAfterBaseType,
trailingTrivia: trailingTrivia
)
}
}
24 changes: 12 additions & 12 deletions Sources/SwiftSyntax/generated/ChildNameForKeyPath.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1207,12 +1207,12 @@ public func childName(_ keyPath: AnyKeyPath) -> String? {
return "unexpectedBetweenEnumKeywordAndIdentifier"
case \EnumDeclSyntax.identifier:
return "identifier"
case \EnumDeclSyntax.unexpectedBetweenIdentifierAndGenericParameters:
return "unexpectedBetweenIdentifierAndGenericParameters"
case \EnumDeclSyntax.genericParameters:
return "genericParameters"
case \EnumDeclSyntax.unexpectedBetweenGenericParametersAndInheritanceClause:
return "unexpectedBetweenGenericParametersAndInheritanceClause"
case \EnumDeclSyntax.unexpectedBetweenIdentifierAndGenericParameterClause:
return "unexpectedBetweenIdentifierAndGenericParameterClause"
case \EnumDeclSyntax.genericParameterClause:
return "genericParameterClause"
case \EnumDeclSyntax.unexpectedBetweenGenericParameterClauseAndInheritanceClause:
return "unexpectedBetweenGenericParameterClauseAndInheritanceClause"
case \EnumDeclSyntax.inheritanceClause:
return "inheritanceClause"
case \EnumDeclSyntax.unexpectedBetweenInheritanceClauseAndGenericWhereClause:
Expand Down Expand Up @@ -2241,12 +2241,12 @@ public func childName(_ keyPath: AnyKeyPath) -> String? {
return "closure"
case \MultipleTrailingClosureElementSyntax.unexpectedAfterClosure:
return "unexpectedAfterClosure"
case \NamedOpaqueReturnTypeSyntax.unexpectedBeforeGenericParameters:
return "unexpectedBeforeGenericParameters"
case \NamedOpaqueReturnTypeSyntax.genericParameters:
return "genericParameters"
case \NamedOpaqueReturnTypeSyntax.unexpectedBetweenGenericParametersAndBaseType:
return "unexpectedBetweenGenericParametersAndBaseType"
case \NamedOpaqueReturnTypeSyntax.unexpectedBeforeGenericParameterClause:
return "unexpectedBeforeGenericParameterClause"
case \NamedOpaqueReturnTypeSyntax.genericParameterClause:
return "genericParameterClause"
case \NamedOpaqueReturnTypeSyntax.unexpectedBetweenGenericParameterClauseAndBaseType:
return "unexpectedBetweenGenericParameterClauseAndBaseType"
case \NamedOpaqueReturnTypeSyntax.baseType:
return "baseType"
case \NamedOpaqueReturnTypeSyntax.unexpectedAfterBaseType:
Expand Down
36 changes: 18 additions & 18 deletions Sources/SwiftSyntax/generated/raw/RawSyntaxNodes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8340,9 +8340,9 @@ public struct RawEnumDeclSyntax: RawDeclSyntaxNodeProtocol {
enumKeyword: RawTokenSyntax,
_ unexpectedBetweenEnumKeywordAndIdentifier: RawUnexpectedNodesSyntax? = nil,
identifier: RawTokenSyntax,
_ unexpectedBetweenIdentifierAndGenericParameters: RawUnexpectedNodesSyntax? = nil,
genericParameters: RawGenericParameterClauseSyntax?,
_ unexpectedBetweenGenericParametersAndInheritanceClause: RawUnexpectedNodesSyntax? = nil,
_ unexpectedBetweenIdentifierAndGenericParameterClause: RawUnexpectedNodesSyntax? = nil,
genericParameterClause: RawGenericParameterClauseSyntax?,
_ unexpectedBetweenGenericParameterClauseAndInheritanceClause: RawUnexpectedNodesSyntax? = nil,
inheritanceClause: RawTypeInheritanceClauseSyntax?,
_ unexpectedBetweenInheritanceClauseAndGenericWhereClause: RawUnexpectedNodesSyntax? = nil,
genericWhereClause: RawGenericWhereClauseSyntax?,
Expand All @@ -8362,9 +8362,9 @@ public struct RawEnumDeclSyntax: RawDeclSyntaxNodeProtocol {
layout[5] = enumKeyword.raw
layout[6] = unexpectedBetweenEnumKeywordAndIdentifier?.raw
layout[7] = identifier.raw
layout[8] = unexpectedBetweenIdentifierAndGenericParameters?.raw
layout[9] = genericParameters?.raw
layout[10] = unexpectedBetweenGenericParametersAndInheritanceClause?.raw
layout[8] = unexpectedBetweenIdentifierAndGenericParameterClause?.raw
layout[9] = genericParameterClause?.raw
layout[10] = unexpectedBetweenGenericParameterClauseAndInheritanceClause?.raw
layout[11] = inheritanceClause?.raw
layout[12] = unexpectedBetweenInheritanceClauseAndGenericWhereClause?.raw
layout[13] = genericWhereClause?.raw
Expand Down Expand Up @@ -8407,15 +8407,15 @@ public struct RawEnumDeclSyntax: RawDeclSyntaxNodeProtocol {
layoutView.children[7].map(RawTokenSyntax.init(raw:))!
}

public var unexpectedBetweenIdentifierAndGenericParameters: RawUnexpectedNodesSyntax? {
public var unexpectedBetweenIdentifierAndGenericParameterClause: RawUnexpectedNodesSyntax? {
layoutView.children[8].map(RawUnexpectedNodesSyntax.init(raw:))
}

public var genericParameters: RawGenericParameterClauseSyntax? {
public var genericParameterClause: RawGenericParameterClauseSyntax? {
layoutView.children[9].map(RawGenericParameterClauseSyntax.init(raw:))
}

public var unexpectedBetweenGenericParametersAndInheritanceClause: RawUnexpectedNodesSyntax? {
public var unexpectedBetweenGenericParameterClauseAndInheritanceClause: RawUnexpectedNodesSyntax? {
layoutView.children[10].map(RawUnexpectedNodesSyntax.init(raw:))
}

Expand Down Expand Up @@ -14876,34 +14876,34 @@ public struct RawNamedOpaqueReturnTypeSyntax: RawTypeSyntaxNodeProtocol {
}

public init(
_ unexpectedBeforeGenericParameters: RawUnexpectedNodesSyntax? = nil,
genericParameters: RawGenericParameterClauseSyntax,
_ unexpectedBetweenGenericParametersAndBaseType: RawUnexpectedNodesSyntax? = nil,
_ unexpectedBeforeGenericParameterClause: RawUnexpectedNodesSyntax? = nil,
genericParameterClause: RawGenericParameterClauseSyntax,
_ unexpectedBetweenGenericParameterClauseAndBaseType: RawUnexpectedNodesSyntax? = nil,
baseType: RawTypeSyntax,
_ unexpectedAfterBaseType: RawUnexpectedNodesSyntax? = nil,
arena: __shared SyntaxArena
) {
let raw = RawSyntax.makeLayout(
kind: .namedOpaqueReturnType, uninitializedCount: 5, arena: arena) { layout in
layout.initialize(repeating: nil)
layout[0] = unexpectedBeforeGenericParameters?.raw
layout[1] = genericParameters.raw
layout[2] = unexpectedBetweenGenericParametersAndBaseType?.raw
layout[0] = unexpectedBeforeGenericParameterClause?.raw
layout[1] = genericParameterClause.raw
layout[2] = unexpectedBetweenGenericParameterClauseAndBaseType?.raw
layout[3] = baseType.raw
layout[4] = unexpectedAfterBaseType?.raw
}
self.init(unchecked: raw)
}

public var unexpectedBeforeGenericParameters: RawUnexpectedNodesSyntax? {
public var unexpectedBeforeGenericParameterClause: RawUnexpectedNodesSyntax? {
layoutView.children[0].map(RawUnexpectedNodesSyntax.init(raw:))
}

public var genericParameters: RawGenericParameterClauseSyntax {
public var genericParameterClause: RawGenericParameterClauseSyntax {
layoutView.children[1].map(RawGenericParameterClauseSyntax.init(raw:))!
}

public var unexpectedBetweenGenericParametersAndBaseType: RawUnexpectedNodesSyntax? {
public var unexpectedBetweenGenericParameterClauseAndBaseType: RawUnexpectedNodesSyntax? {
layoutView.children[2].map(RawUnexpectedNodesSyntax.init(raw:))
}

Expand Down
30 changes: 15 additions & 15 deletions Sources/SwiftSyntax/generated/syntaxNodes/SyntaxDeclNodes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1765,9 +1765,9 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
enumKeyword: TokenSyntax = .keyword(.enum),
_ unexpectedBetweenEnumKeywordAndIdentifier: UnexpectedNodesSyntax? = nil,
identifier: TokenSyntax,
_ unexpectedBetweenIdentifierAndGenericParameters: UnexpectedNodesSyntax? = nil,
genericParameters: GenericParameterClauseSyntax? = nil,
_ unexpectedBetweenGenericParametersAndInheritanceClause: UnexpectedNodesSyntax? = nil,
_ unexpectedBetweenIdentifierAndGenericParameterClause: UnexpectedNodesSyntax? = nil,
genericParameterClause: GenericParameterClauseSyntax? = nil,
_ unexpectedBetweenGenericParameterClauseAndInheritanceClause: UnexpectedNodesSyntax? = nil,
inheritanceClause: TypeInheritanceClauseSyntax? = nil,
_ unexpectedBetweenInheritanceClauseAndGenericWhereClause: UnexpectedNodesSyntax? = nil,
genericWhereClause: GenericWhereClauseSyntax? = nil,
Expand All @@ -1788,9 +1788,9 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
enumKeyword,
unexpectedBetweenEnumKeywordAndIdentifier,
identifier,
unexpectedBetweenIdentifierAndGenericParameters,
genericParameters,
unexpectedBetweenGenericParametersAndInheritanceClause,
unexpectedBetweenIdentifierAndGenericParameterClause,
genericParameterClause,
unexpectedBetweenGenericParameterClauseAndInheritanceClause,
inheritanceClause,
unexpectedBetweenInheritanceClauseAndGenericWhereClause,
genericWhereClause,
Expand All @@ -1807,9 +1807,9 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
enumKeyword.raw,
unexpectedBetweenEnumKeywordAndIdentifier?.raw,
identifier.raw,
unexpectedBetweenIdentifierAndGenericParameters?.raw,
genericParameters?.raw,
unexpectedBetweenGenericParametersAndInheritanceClause?.raw,
unexpectedBetweenIdentifierAndGenericParameterClause?.raw,
genericParameterClause?.raw,
unexpectedBetweenGenericParameterClauseAndInheritanceClause?.raw,
inheritanceClause?.raw,
unexpectedBetweenInheritanceClauseAndGenericWhereClause?.raw,
genericWhereClause?.raw,
Expand Down Expand Up @@ -1944,7 +1944,7 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
}
}

public var unexpectedBetweenIdentifierAndGenericParameters: UnexpectedNodesSyntax? {
public var unexpectedBetweenIdentifierAndGenericParameterClause: UnexpectedNodesSyntax? {
get {
return data.child(at: 8, parent: Syntax(self)).map(UnexpectedNodesSyntax.init)
}
Expand All @@ -1954,7 +1954,7 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
}

/// The generic parameters, if any, for this enum declaration.
public var genericParameters: GenericParameterClauseSyntax? {
public var genericParameterClause: GenericParameterClauseSyntax? {
get {
return data.child(at: 9, parent: Syntax(self)).map(GenericParameterClauseSyntax.init)
}
Expand All @@ -1963,7 +1963,7 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
}
}

public var unexpectedBetweenGenericParametersAndInheritanceClause: UnexpectedNodesSyntax? {
public var unexpectedBetweenGenericParameterClauseAndInheritanceClause: UnexpectedNodesSyntax? {
get {
return data.child(at: 10, parent: Syntax(self)).map(UnexpectedNodesSyntax.init)
}
Expand Down Expand Up @@ -2039,9 +2039,9 @@ public struct EnumDeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
\Self.enumKeyword,
\Self.unexpectedBetweenEnumKeywordAndIdentifier,
\Self.identifier,
\Self.unexpectedBetweenIdentifierAndGenericParameters,
\Self.genericParameters,
\Self.unexpectedBetweenGenericParametersAndInheritanceClause,
\Self.unexpectedBetweenIdentifierAndGenericParameterClause,
\Self.genericParameterClause,
\Self.unexpectedBetweenGenericParameterClauseAndInheritanceClause,
\Self.inheritanceClause,
\Self.unexpectedBetweenInheritanceClauseAndGenericWhereClause,
\Self.genericWhereClause,
Expand Down
Loading