Implement editor placeholder parsing logic in SwiftSyntax #2878
Conversation
|
swiftlang/sourcekit-lsp#1746 |
| } | ||
|
|
||
| @_spi(RawSyntax) | ||
| public func parseEditorPlaceholder(syntaxText: SyntaxText) -> RawEditorPlaceholderData? { |
There was a problem hiding this comment.
Should this be an initializer on RawEditorPlaceholderData?
There was a problem hiding this comment.
Made this function private and introduced RawEditorPlaceholderData.init?(syntaxText:)
| case typed(text: Substring, type: TypeSyntax) | ||
| private struct EditorPlaceholderExpansionData { | ||
| let displayText: String | ||
| let type: TypeSyntax? |
There was a problem hiding this comment.
Should this be typeForExpansion to match the member name in RawEditorPlaceholderExpansionData?
rintaro
force-pushed
the
raw-editor-placeholder
branch
from
cdb1228 to
7cde6c3
Compare
|
swiftlang/sourcekit-lsp#1746 |
rintaro
force-pushed
the
raw-editor-placeholder
branch
from
7cde6c3 to
58a2cbb
Compare
|
swiftlang/sourcekit-lsp#1746 |
|
swiftlang/sourcekit-lsp#1746 |
|
swiftlang/swift#76943 |
1 similar comment
|
swiftlang/swift#76943 |
So it can be used from other clients.
rintaro
force-pushed
the
raw-editor-placeholder
branch
from
58a2cbb to
d908703
Compare
|
swiftlang/sourcekit-lsp#1746 |
|
swiftlang/sourcekit-lsp#1746 |
|
swiftlang/sourcekit-lsp#1746 |
1 similar comment
|
swiftlang/sourcekit-lsp#1746 |
So it can be used from other clients.
RawEditorPlaceholderData(syntaxText:)Parse a placeholder text<#...#>and instantiateSwiftSyntax.RawEditorPlaceholderData.RawEditorPlaceholderDataholds the parsed data, similar to C++ compiler'sEditorPlaceholderData