[CodeGeneration] Minimize per-type parse(from:) code
#2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
approved these changes
Feb 24, 2025
Comment on lines
39
to
44
| public static func parse(from parser: inout Parser) -> Self { | ||
| // Keep the parser alive so that the arena in which `raw` is allocated | ||
| // doesn’t get deallocated before we have a chance to create a syntax node | ||
| // from it. We can’t use `parser.arena` as the parameter to | ||
| // `Syntax(raw:arena:)` because the node might have been re-used during an | ||
| // incremental parse and would then live in a different arena than | ||
| // `parser.arena`. | ||
| defer { withExtendedLifetime(parser) {} } | ||
| let node = Self.parseRaw(from: &parser) | ||
| let raw = RawSyntax(parser.parseRemainder(into: node)) | ||
| return Syntax(raw: raw, rawNodeArena: raw.arena).cast(Self.self) | ||
| } |
There was a problem hiding this comment.
Could you use 2 space for indentation here?
rintaro
force-pushed
the
layout-parseable-impl
branch
2 times, most recently
from
7b87b12 to
56f47e3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
approved these changes
Feb 26, 2025
rintaro
force-pushed
the
layout-parseable-impl
branch
from
56f47e3 to
3981815
Compare
Use a delegating function `SyntaxParseable.parse(from:parse:)` similar to the collection node version `SyntaxCollection.parse(from:parse:makeMissing`.
rintaro
force-pushed
the
layout-parseable-impl
branch
from
3981815 to
2d3ba35
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windwos |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce internal
SyntaxParseableImplprotocol which provides the implementation of the reminder parsing, and theRawSyntax->Syntaxbridging.