[SE-0458] Enable unsafe expressions and for..in effects everywhere
#2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imental Keep the experimental feature around for just a moment so we don't have to pair commits across the swift-syntax and swift repositories.
Only treat `unsafe` as starting an unsafe expression if the following token is on the same line and isn't a `)`. The former is in line with how we handle other modifier expressions like this, and the latter is because of the archaic `@MainActor(unsafe)`.
|
@swift-ci please test |
ahoppen
approved these changes
Feb 26, 2025
This was referenced Feb 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the acceptance of SE-0458, stop using the
unsafeExpressionexperimental feature to gate theunsafeexpression and for..in effect.Improve disambiguation for the
unsafeexpression slightly to account for this.