Skip to content

[Windows] Remove extra newlines from diagnostic output. #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Apr 3, 2025

We are outputting lots of extra newlines on Windows, which makes it hard to read the diagnostics.

rdar://148520063

@al45tair
Copy link
Contributor Author

al45tair commented Apr 3, 2025

@swift-ci Please test

@al45tair al45tair requested a review from compnerd April 3, 2025 17:09
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @al45tair!

We are outputting lots of extra newlines on Windows, which makes it
hard to read the diagnostics.

rdar://148520063
@al45tair
Copy link
Contributor Author

al45tair commented Apr 4, 2025

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Apr 5, 2025

@swift-ci Please test Windows platform

@al45tair al45tair merged commit 6c53107 into swiftlang:main Apr 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants