Improve BumpPtrAllocator performance #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
Eliminate unnecessary slab array access when allocating from the current slab. Also factored out "allocate from the current slab" to a function.
rintaro
force-pushed
the
bump-ptr-allocator-perf
branch
from
4d7d64e to
db3c85e
Compare
rintaro
commented
Aug 19, 2022
| @@ -79,12 +98,8 @@ public class BumpPtrAllocator { | |||
| _totalBytesAllocated += byteCount | |||
|
|
|||
| // Check if the current slab has enough space. | |||
| if !slabs.isEmpty { | |||
There was a problem hiding this comment.
This was the "unnecessary slab array access."
|
@swift-ci Please test |
ahoppen
approved these changes
Aug 19, 2022
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate unnecessary slab array access when allocating from the current slab. Also factored out "allocate from the current slab" to a function.