Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "override comment" from ConditionTrait implementation #1036

Merged

Conversation

stmontgomery
Copy link
Contributor

This removes a mechanism in the implementation of ConditionTrait for a condition closure to provide an "override" comment.

Motivation:

While reviewing a draft evolution proposal for ConditionTrait (swiftlang/swift-evolution#2740) I realized that we don't use this "comment override" mechanism anywhere in the testing library. I believe we did back when it was first added, but it's no longer used.

Removing this would allow the public API being proposed above to be simplified: the evaluate() method could return Bool instead of a tuple.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added enhancement New feature or request traits Issues and PRs related to the trait subsystem or built-in traits labels Mar 24, 2025
@stmontgomery stmontgomery added this to the Swift 6.2 milestone Mar 24, 2025
@stmontgomery stmontgomery self-assigned this Mar 24, 2025
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor Author

Related to #903

cc @Uncommon

@stmontgomery stmontgomery merged commit 2c60dd6 into swiftlang:main Mar 25, 2025
3 checks passed
@stmontgomery stmontgomery deleted the remove-ConditionTrait-return-comment branch March 25, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request traits Issues and PRs related to the trait subsystem or built-in traits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants