Use the entire SHA-256 hash as an exit test ID. #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses the entire 256 bits of the computed SHA-256 hash for an exit test's ID, not just the first 128. They're there, might as well use them.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test Linux |
briancroom
approved these changes
Apr 7, 2025
grynspan
added a commit
that referenced
this pull request
Apr 7, 2025
This PR uses the entire 256 bits of the computed SHA-256 hash for an exit test's ID, not just the first 128. They're there, might as well use them. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Apr 8, 2025
- **Explanation**: Uses the full 256 bits from a SHA-256 hash to uniquely identify an exit test instead of truncating to 128 bits. - **Scope**: Exit test IDs - **Issues**: N/A - **Original PRs**: #1053 - **Risk**: Low (everything involved is recompiled) - **Testing**: Normal CI jobs. - **Reviewers**: @briancroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the entire 256 bits of the computed SHA-256 hash for an exit test's ID, not just the first 128. They're there, might as well use them.
Checklist: