Skip to content

Include total number of suites in "run ended" console message #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

stmontgomery
Copy link
Contributor

This enhances the console output message shown when a test run finishes by including the total number of suites which ran or skipped, after the total number of test functions. Example:

✔ Test run with 456 tests in 62 suites passed after 3.389 seconds.

The data was already being collected to support this, in a property named suiteCount, but it was not being used anywhere. So this PR adopts that property to augment the current "test run ended" message.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added this to the Swift 6.x milestone May 15, 2025
@stmontgomery stmontgomery self-assigned this May 15, 2025
@stmontgomery stmontgomery added enhancement New feature or request command-line experience ⌨️ enhancements to the command line interface labels May 15, 2025
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@@ -550,14 +551,14 @@ extension Event.HumanReadableOutputRecorder {
[
Message(
symbol: .fail,
stringValue: "Test run with \(testCount.counting("test")) failed after \(duration)\(issues.description)."
stringValue: "Test run with \(testCount.counting("test")) in \(suiteCount.counting("suite")) failed after \(duration)\(issues.description)."
Copy link
Contributor Author

@stmontgomery stmontgomery May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose the word "in" here, although we could alternatively choose "and", as in Test run with X tests and Y suites passed…. Open to suggestions.

@briancroom
Copy link
Contributor

Nice, I like it!

@stmontgomery stmontgomery merged commit 17c00b0 into swiftlang:main May 16, 2025
3 checks passed
@stmontgomery stmontgomery deleted the suite-count branch May 16, 2025 16:47
finagolfin added a commit to swiftlang/swift-integration-tests that referenced this pull request May 17, 2025
@stmontgomery stmontgomery modified the milestones: Swift 6.x, Swift 6.2 May 24, 2025
finagolfin added a commit to swiftlang/swift-integration-tests that referenced this pull request May 25, 2025
finagolfin added a commit to swiftlang/swift-integration-tests that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-line experience ⌨️ enhancements to the command line interface enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants