Define and implement a strawman stable JSON schema for output. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
|
@swift-ci please test |
|
@swift-ci please test Linux |
grynspan
force-pushed
the
jgrynspan/defining-json-schema
branch
from
4a13767 to
b6f6b87
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/defining-json-schema
branch
2 times, most recently
from
dcb933e to
6cdc0ca
Compare
grynspan
changed the title
grynspan
force-pushed
the
jgrynspan/defining-json-schema
branch
from
6cdc0ca to
fb2d51a
Compare
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
force-pushed
the
jgrynspan/defining-json-schema
branch
from
fb2d51a to
f0a4206
Compare
|
@swift-ci please test |
plemarquand
reviewed
May 9, 2024
plemarquand
approved these changes
May 9, 2024
stmontgomery
reviewed
May 9, 2024
| /// This event is the first event posted after ``Runner/run()`` is called. | ||
| case runStarted | ||
| indirect case runStarted(_ plan: Runner.Plan) |
There was a problem hiding this comment.
I suspect this is added because it's used elsewhere, but isn't this quite a large payload potentially? I wonder about the impact of that
But also (ironically): if we do add this here, for parity should we also be adding it to the corresponding run ended event?
There was a problem hiding this comment.
It's pretty chunky, yes, but remember that the value is CoW, so not as large as you might think. I'm open to alternative designs.
I left it out of the runEnded case precisely because it was relatively large.
stmontgomery
reviewed
May 9, 2024
| // | ||
|
|
||
| /// A namespace for ABI version 0 symbols. | ||
| enum ABIv0: Sendable {} |
There was a problem hiding this comment.
Not for right now, but if/when we expose this outside the module I'd like to bikeshed alternative naming conventions
There was a problem hiding this comment.
This enum is definitely not ever meant to be API. It's a namespace for ABI-version-0 symbols only.
I'm open to alternatives.
stmontgomery
reviewed
May 9, 2024
stmontgomery
reviewed
May 9, 2024
Sources/Testing/EntryPoints/ABIv0/Encoded/ABIv0.EncodedMessage.swift
Outdated
Show resolved
Hide resolved
stmontgomery
reviewed
May 9, 2024
Sources/Testing/EntryPoints/ABIv0/Encoded/ABIv0.EncodedMessage.swift
Outdated
Show resolved
Hide resolved
stmontgomery
reviewed
May 9, 2024
Sources/Testing/EntryPoints/ABIv0/Encoded/ABIv0.EncodedEvent.swift
Outdated
Show resolved
Hide resolved
stmontgomery
reviewed
May 9, 2024
Sources/Testing/EntryPoints/ABIv0/Encoded/ABIv0.EncodedEvent.swift
Outdated
Show resolved
Hide resolved
dennisweissmann
approved these changes
May 10, 2024
stmontgomery
approved these changes
May 10, 2024
stmontgomery
approved these changes
May 10, 2024
|
@swift-ci please test |
grynspan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 10, 2024
Follow-on to #7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
grynspan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 10, 2024
…7551) Follow-on to #7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…wiftlang#7551) Follow-on to swiftlang#7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
grynspan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 15, 2024
…7551) Follow-on to #7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…wiftlang#7551) Follow-on to swiftlang#7534. swift-testing has an additional argument specifying the schema version of the JSON being used that we also need to pass through SwiftPM. See: swiftlang/swift-testing#383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a JSON schema for events output from swift-testing via either
--experimental-event-stream-outputorabiEntryPoint_v0(). The JSON schema needs to be formally reviewed separately.We are already writing an experimental JSON stream using "snapshot" types and we don't want to break folks experimenting with it before we have a final JSON schema, so for now that remains the default. To opt into the new schema, pass
--experimental-event-stream-version 0(note that this argument is not forwarded fromswift test. See swiftlang/swift-package-manager#7534.)Resolves #368.
Checklist: