Work around test discovery crash when running on older OS versions due to unguarded use of .timeLimit #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to unguarded use of .timeLimit
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
… not directly relevant there
|
@swift-ci please test |
stmontgomery
commented
May 9, 2024
| // where traits with conditional API availability are not guarded by | ||
| // `@available` attributes on their associated `@Test` function | ||
| // (rdar://127811571). That is not directly relevant here but is worth noting | ||
| // if this trait is ever applied to `@Test` functions in this file. |
There was a problem hiding this comment.
No functional change in this file, just noting this related bug
grynspan
approved these changes
May 9, 2024
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a test discovery crash when running on older Apple OS versions which don't support
Clockand related APIs.Checklist: