Skip to content

Don't use memcpy() in a unit test. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Don't use memcpy() in a unit test. #423

merged 1 commit into from
May 18, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented May 18, 2024 •
edited
Loading

This PR changes from memcpy() to the Swiftier UnsafeMutableRawBufferPointer.copyMemory(from:).

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Don't use memcpy() in a unit test.
e3b933c 
This PR changes from `memcpy()` to the Swiftier
`UnsafeMutableRawBufferPointer.copyMemory(from:)`.
@grynspan grynspan added the bug 🪲 Something isn't working label May 18, 2024
@grynspan grynspan self-assigned this May 18, 2024
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

Windows failure is a known compiler issue.

@grynspan grynspan merged commit d109ed0 into main May 18, 2024
2 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/no-memcpy branch May 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisweissmann dennisweissmann dennisweissmann approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @dennisweissmann