Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWT-0004] Constrain the granularity of test time limit durations #534

Merged
merged 5 commits into from
Jul 26, 2024
Merged

[SWT-0004] Constrain the granularity of test time limit durations #534

merged 5 commits into from
Jul 26, 2024

Conversation

dennisweissmann
Copy link
Contributor

@dennisweissmann dennisweissmann commented Jul 13, 2024 •
edited by grynspan
Loading

API proposal for promoting TimeLimitTrait.Duration and associated declarations to API.

View the full proposal here.

@dennisweissmann dennisweissmann added public-api Affects public API api-proposal API proposal PRs (documentation only) labels Jul 13, 2024
@dennisweissmann dennisweissmann self-assigned this Jul 13, 2024
@dennisweissmann dennisweissmann changed the title [API Proposal] Promote TimeLimitTrait.Duration and associated declarations to API [API Proposal] Constrain the granularity of test time limit durations Jul 13, 2024
@grynspan grynspan changed the title [API Proposal] Constrain the granularity of test time limit durations [SWT-NNNN] Constrain the granularity of test time limit durations Jul 13, 2024
@dennisweissmann dennisweissmann force-pushed the dweissmann/127625073 branch 2 times, most recently from 7b2a8e4 to c624d10 Compare July 25, 2024 19:44
@dennisweissmann dennisweissmann changed the title [SWT-NNNN] Constrain the granularity of test time limit durations [SWT-0004] Constrain the granularity of test time limit durations Jul 25, 2024
@grynspan
Copy link
Contributor

Please don't force-push changes once review has started (except for rebasing of course.) Incremental commits allow us to clearly view what you've changed. Thanks!

@dennisweissmann
Copy link
Contributor Author

Please don't force-push changes once review has started (except for rebasing of course.) Incremental commits allow us to clearly view what you've changed. Thanks!

Sorry, I'm used to force-pushing. GitHub has this "Compare" button that shows the difference between the old and new commit(s). I'll still try to remember not to force-push here.

Screenshot 2024-07-25 at 13 16 05

@grynspan
Copy link
Contributor

@swift-ci please test

@grynspan grynspan merged commit 3c2c406 into main Jul 26, 2024
3 checks passed
@grynspan grynspan deleted the dweissmann/127625073 branch July 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@grynspan grynspan grynspan approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@dennisweissmann dennisweissmann

Labels
api-proposal API proposal PRs (documentation only) public-api Affects public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisweissmann @grynspan @briancroom