[6.0] Fix incorrectly-specified platform list in CMake file. #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CMake file that sets compiler conditionals has the wrong syntax when setting `SWT_NO_EXIT_TESTS` conditionally. Fix that. (With thanks to @compnerd.)
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
compnerd
approved these changes
Aug 22, 2024
briancroom
approved these changes
Aug 23, 2024
grynspan
deleted the
jgrynspan/misspecified-cmake-SWT_NO_EXIT_TESTS-6.0
branch
grynspan
restored the
jgrynspan/misspecified-cmake-SWT_NO_EXIT_TESTS-6.0
branch
|
Merged to the wrong branch. 🤦 |
grynspan
deleted the
jgrynspan/misspecified-cmake-SWT_NO_EXIT_TESTS-6.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Correctly sets
SWT_NO_EXIT_TESTSon platforms that don't support them when building with CMake.Scope: Building iOS, watchOS, tvOS, visionOS, WASI from OSS.
Issue: N/A
Original PR: #633
Risk: Low
Testing: Manually tested as we don't have CI using CMake yet.
Reviewer: @compnerd @briancroom