Don't use Synchronization.Atomic for deliverExpectationCheckedEvents.
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts`. This PR replaces the new use of `Atomic<Int>` with a `Locked<Int>` in the implementation of `deliverExpectationCheckedEvents`. Why? Because we're running into some environments where the Synchronization module isn't available (e.g. older host macOSes) and this is simpler. The performance profile is comparable: on my system, running the `repeatedlyExpect()` test takes 0.55s instead of 0.49s to call `#expect()` 1,000,000 times, so it's still a significant win over the implementation we had earlier.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
approved these changes
Sep 6, 2024
grynspan
added a commit
that referenced
this pull request
Sep 6, 2024
…edEvents`. (#667) **Explanation:** Drops use of `Atomic<Int>` which is giving us some grief in some build environments where the Synchronization module isn't available. **Scope:** 6.0 branch **Issue:** N/A **Original PR:** #666 **Risk:** Low **Testing:** Existing coverage. **Reviewer:** @briancroom @suzannaratcliff @stmontgomery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the new use of
Atomic<Int>with aLocked<Int>in the implementation ofdeliverExpectationCheckedEvents. Why? Because we're running into some environments where the Synchronization module isn't available (e.g. older host macOSes) and this is simpler. The performance profile is comparable: on my system, running therepeatedlyExpect()test takes 0.55s instead of 0.49s to call#expect()1,000,000 times, so it's still a significant win over the implementation we had earlier.Checklist: