Fix a typo in a call of install path getter function name #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up fix to f078f7a that I made at the last minute before merging...
kateinoigakukun
requested review from
stmontgomery,
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
Including `sys/resource.h` from wasi-libc requires a feature macro to be defined (`-D_WASI_EMULATED_PROCESS_CLOCKS`) and emits compilation errors otherwise. However, the header is not used in WASI paths, so it is safe to exclude it from the list of includes. See `sys/times.h` that is transitively included by `sys/resource.h` https://github.com/WebAssembly/wasi-libc/blob/wasi-sdk-22/libc-top-half/musl/include/sys/times.h
grynspan
reviewed
Sep 8, 2024
|
@swift-ci test |
grynspan
approved these changes
Sep 8, 2024
grynspan
added
bug
MaxDesiatov
approved these changes
Sep 8, 2024
stmontgomery
approved these changes
Sep 8, 2024
|
@kateinoigakukun Note if you need this fix in Swift 6.0.1, please clone the PR and nominate it using the procedure outlined here. |
stmontgomery
referenced
this pull request
Sep 17, 2024
- **Explanation**: Switch to the official [600.0.0 tag](https://github.com/swiftlang/swift-syntax/releases/tag/600.0.0) for swift-syntax, which was recently created. - **Original PR**: [#651 https://github.com/swiftlang/swift-testing/pull/672](https://github.com/swiftlang/swift-testing/pull/690) - **Risk**: Low - **Testing**: Tested in ci.swift.org - **Reviewer**: @grynspan @briancroom
stmontgomery
referenced
this pull request
Sep 20, 2024
- **Explanation**: Switch to the official [600.0.0 tag](https://github.com/swiftlang/swift-syntax/releases/tag/600.0.0) for swift-syntax, which was recently created. - **Original PR**: [#651 https://github.com/swiftlang/swift-testing/pull/672](https://github.com/swiftlang/swift-testing/pull/690) - **Risk**: Low - **Testing**: Tested in ci.swift.org - **Reviewer**: @grynspan @briancroom
grynspan
pushed a commit
that referenced
this pull request
Sep 24, 2024
- **Explanation**: When building the Testing library as a static library (BUILD_SHARED_LIBS=FALSE), `_TestingInternals` is not included in the `libTesting.a` archive by default. (when building as a shared library, `libTesting.so` includes `_TestingInternals` objects). This causes the linker to complain about missing symbols, so we need to ship `lib_TestingInternals.a` and autolink it too. - **Original PR**: #651 #672 - **Risk**: Low; NFC for non WASI platforms - **Testing**: Tested in ci.swift.org - **Reviewer**: @grynspan @briancroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix to f078f7a that I made at the last minute before merging...