Preserve verbosity argument in HumanReadableOutputRecorder.record().
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR restores/undeprecates the `verbosity` argument to `HumanReadableOutputRecorder.record()` that was deprecated in #677. We still need to be able to override the command-line-specified value in the event stream.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
commented
Sep 17, 2024
| in eventContext: borrowing Event.Context, | ||
| verbosity: Int? = nil | ||
| ) -> [Message] { | ||
| let verbosity: Int = if let verbosity { |
There was a problem hiding this comment.
Can't use the Elvis operator (??) with borrowed values (yet.)
stmontgomery
approved these changes
Sep 17, 2024
|
@swift-ci test |
grynspan
deleted the
jgrynspan/undeprecate-human-readable-output-verbosity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores/undeprecates the
verbosityargument toHumanReadableOutputRecorder.record()that was deprecated in #677. We still need to be able to override the command-line-specified value in the event stream.Checklist: