Make the ExitTest type move-only.
#712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `~Copyable` to `ExitTest`, which is a tools-only bit of SPI representing a (gasp) exit test. This change has the effect of making it impossible to accidentally invoke an exit test body in the parent process, and also impossible to accidentally invoke twice in the child process. Phew!
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
approved these changes
Sep 18, 2024
briancroom
approved these changes
Sep 18, 2024
stmontgomery
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
~CopyabletoExitTest, which is a tools-only bit of SPI representing a (gasp) exit test. This change has the effect of making it impossible to accidentally invoke an exit test body in the parent process, and also impossible to accidentally invoke twice in the child process. Phew!Checklist: