Skip to content

[6.0.2][CMake] Explicitly link Testing to Foundation #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2024
Merged

[6.0.2][CMake] Explicitly link Testing to Foundation #713

merged 3 commits into from
Sep 24, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 18, 2024 •
edited by grynspan
Loading

Cherry-pick #693 into release/6.0.2

  • Explanation: Previously in CMake builds, when Foundation was not in the regular search directory (e.g. resource directory or SDK search paths) #if canImport(Foundation) used to fail, and the functionalities are not included. This patch provides a way to provide Foundation_DIR for find_packgage(Foundation CONFIG), so that clients can correctly link Testing to Foundation
  • Scope: CMake builds
  • Risk: Low. No actual code changes.
  • Testing: Passes current test suite Also manually tested the build toolchain
  • Issues: N/A
  • Reviewer: @stmontgomery

@rintaro
[CMake] Explicitly link Testing to Foundation
e93765f 
(cherry picked from commit 79a443a)
@rintaro
Don't link to dispatch in WASI
a60d685 
WASI doesn't support `libdispatch`

(cherry picked from commit c2f8ccc)
@rintaro rintaro mentioned this pull request Sep 18, 2024
Merged
@rintaro rintaro self-assigned this Sep 18, 2024
@shahmishal shahmishal changed the base branch from release/6.0.1 to release/6.0.2 September 20, 2024 05:21
@stmontgomery stmontgomery added windows 🪟 Windows support build 🧱 Affects the project's build configuration or process labels Sep 20, 2024
@stmontgomery stmontgomery added the bug 🪲 Something isn't working label Sep 20, 2024
@grynspan grynspan changed the title [6.0.1][CMake] Explicitly link Testing to Foundation [6.0.2][CMake] Explicitly link Testing to Foundation Sep 20, 2024
@grynspan grynspan added this to the Swift 6.0.2 milestone Sep 20, 2024
@grynspan
Copy link
Contributor

@swift-ci test

@grynspan grynspan merged commit cd448bb into swiftlang:release/6.0.2 Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann dennisweissmann is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@rintaro rintaro

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process windows 🪟 Windows support
Projects
None yet
Milestone
Swift 6.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rintaro @grynspan @stmontgomery @briancroom