Distinguish when an error is part of a recorded issue in an exit test. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exit test records an issue of kind `.errorCaught()`, we currently treat it
the same as any other issue and translate it to a flat `.unconditional` issue in
the parent process:
```swift
await #expect(exitsWith: .failure) {
Issue.record(NoSuchWeaselError()) // unconditional issue recorded
}
```
This PR distinguishes the `.errorCaught` issue kind and records an
`.errorCaught` issue in the parent process. Fidelity of errors across a process
boundary is weak, but we encode a minimal representation of the error that
should be good enough for most uses. If you need `withKnownIssue()`, or
`#expect(throws:)`, you can call them _inside_ the exit test.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
approved these changes
Sep 26, 2024
grynspan
deleted the
jgrynspan/distinguish-recorded-errors-from-other-issues-in-exit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of #697…
If an exit test records an issue of kind
.errorCaught(), we currently treat it the same as any other issue and translate it to a flat.unconditionalissue in the parent process:This PR distinguishes the
.errorCaughtissue kind and records an.errorCaughtissue in the parent process. Fidelity of errors across a process boundary is weak, but we encode a minimal representation of the error that should be good enough for most uses. If you needwithKnownIssue(), or#expect(throws:), you can call them inside the exit test.Checklist: