Remove extraneous @escaping and @Sendable attributes from CustomExecutionTrait.execute(...) SPI #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refines the
CustomExecutionTrait
SPI protocol by removing two unnecessary attributes from the signature of itsexecute(_:for:testCase:)
method requirement:@escaping
attribute on thefunction
parameter was needed originally to avoid a warning, butfunction
should not actually be considered escaping and part of the contract of this interface is that the implementor must call it before returning. The compiler no longer complains about this, so we can enforce this requirement by removing the unnecessary@escaping
attribute now.@Sendable
was necessary when this SPI was first written to avoid a Swift concurrency warning, since a reference to the function is taken elsewhere in the codebase, but this is no longer needed in recent Swift compilers.Checklist: