Split SWT_NO_EXIT_TESTS into SWT_NO_EXIT_TESTS and SWT_NO_PROCESS_SPAWNING.
#769
+91
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S_SPAWNING`. This PR separates out our process-spawning code to be guarded by `SWT_NO_PROCESS_SPAWNING` instead of `SWT_NO_EXIT_TESTS`. We do this so that we can potentially use process spawning on platforms where exit tests are not supported for some other reason (such as the iOS/Android sandboxes) but process spawning is still internally possible. There are a few use cases we have for spawning processes that don't involve exit tests: - Calling out to `tar` to compress attachments (see #714) - Running non-Swift scripts in their interpreters (see #478) - Multi-process parallelism (the XCTest model) I took the opportunity to clean up WaitFor.swift a bit and rearrange code so that the "new platform, dunno who lives here" case should compile (although not function) out-of-the-box.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
approved these changes
Oct 17, 2024
grynspan
added a commit
that referenced
this pull request
Oct 18, 2024
This PR was supposed to be part of #769, but I must have blown away a local commit because it didn't make it into that PR. This PR updates Porting.md to explain when a developer might encounter an error due to mismatched `SWT_` conditions. It ensures that exit tests require process spawning to be enabled/implemented by adding a dependency between `SWT_NO_PROCESS_SPAWNING` and `SWT_NO_EXIT_TESTS`. This PR also tweaks which bits of `ExitTest` are exposed on platforms that do not support exit tests at all. The type needs to be exposed so that `ExitTest.Result` is exposed so that we can correctly expose `#expect(exitsWith:)` and `#require(exitsWith:)` while marking them unavailable, as opposed to hiding the macros and not giving a developer clear diagnostics.
2 tasks
grynspan
added a commit
that referenced
this pull request
Oct 18, 2024
…s. (#772) This PR was supposed to be part of #769, but I must have blown away a local commit because it didn't make it into that PR. This PR updates Porting.md to explain when a developer might encounter an error due to mismatched `SWT_` conditions. It ensures that exit tests require process spawning to be enabled/implemented by adding a dependency between `SWT_NO_PROCESS_SPAWNING` and `SWT_NO_EXIT_TESTS`. This PR also tweaks which bits of `ExitTest` are exposed on platforms that do not support exit tests at all. The type needs to be exposed so that `ExitTest.Result` is exposed so that we can correctly expose `#expect(exitsWith:)` and `#require(exitsWith:)` while marking them unavailable, as opposed to hiding the macros and not giving a developer clear diagnostics. ### Checklist: - [ ] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [ ] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out our process-spawning code to be guarded by
SWT_NO_PROCESS_SPAWNINGinstead ofSWT_NO_EXIT_TESTS. We do this so that we can potentially use process spawning on platforms where exit tests are not supported for some other reason (such as the iOS/Android sandboxes) but process spawning is still internally possible.There are a few use cases we have for spawning processes that don't involve exit tests:
tarto compress attachments (see Add attachments #714)I took the opportunity to clean up WaitFor.swift a bit and rearrange code so that the "new platform, dunno who lives here" case should compile (although not function) out-of-the-box.
Checklist: