Avoid using NTSTATUS near exit().
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, `NTSTATUS` is a typedef of `long`. On 32-bit Windows, `long` is imported into Swift as `Int` but on 64-bit Windows,it's imported as `Int32`. These types are layout-equivalent but not implicitly convertible, so we get errors on 32-bit Windows when using an `NTSTATUS` (i.e. `Int`) where a `CInt` (i.e. `Int32`) is expected. This PR changes the types of the constants introduced in #766 to be explicitly `CInt` so that they are usable on both flavours of Windows.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
dschaefer2
approved these changes
Oct 21, 2024
plemarquand
approved these changes
Oct 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
NTSTATUSis a typedef oflong. On 32-bit Windows,longis imported into Swift asIntbut on 64-bit Windows,it's imported asInt32. These types are layout-equivalent but not implicitly convertible, so we get errors on 32-bit Windows when using anNTSTATUS(i.e.Int) where aCInt(i.e.Int32) is expected.This PR changes the types of the constants introduced in #766 to be explicitly
CIntso that they are usable on both flavours of Windows.Checklist: