Work around a crash importing FoundationXML. #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR works around a new crash importing FoundationXML See: https://ci-external.swift.org/job/swift-testing-pull-request-windows/832/ https://ci.swift.org/job/pr-swift-testing-linux-5.10/1319/console Works around rdar://138761752.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
approved these changes
Oct 28, 2024
|
@grynspan Looks like we may be able to revert this now that swiftlang/swift#77309 has been merged. Care to do so? |
2 tasks
grynspan
added a commit
that referenced
this pull request
Jan 6, 2025
This reverts commit 405d8c9. The issue should no longer be occurring. See #786. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around a new crash importing FoundationXML See:
Works around rdar://138761752.
Checklist: