Fix a crash when describing a confirmation failure with a range. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using `relative(to:)` to convert any arbitrary `RangeExpression` to one with an upper and lower bound, but that function may produce invalid ranges for expressions like `1...` that cause crashes. This PR switches to a different, somewhat sillier implementation that should not run into this issue. Resolves #805.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
approved these changes
Nov 4, 2024
stmontgomery
reviewed
Nov 4, 2024
briancroom
approved these changes
Nov 4, 2024
2 tasks
grynspan
added a commit
that referenced
this pull request
Nov 11, 2024
My previous fix, #806, had the wrong logic to determine if a confirmation's expected count as-a-`RangeExpression` had exactly one value, so we were printing sub-optimal messages on test failures. Specifically, this: ```swift await confirmation(expectedCount: 1) { // transformed to 1...1 // fail to confirm } ``` Would report "1...1 time(s)" instead of "1 time". ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
relative(to:)to convert any arbitraryRangeExpressionto one with an upper and lower bound, but that function may produce invalid ranges for expressions like1...that cause crashes.This PR switches to a different, somewhat sillier implementation that should not run into this issue.
Resolves #805.
Resolves rdar://139222774.
Checklist: