Skip to content

Work around Windows build failure due to SwiftPM regression. #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 11, 2024
Merged

Work around Windows build failure due to SwiftPM regression. #816

merged 12 commits into from
Nov 11, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Nov 11, 2024 •
edited
Loading

Works around a link-time bug in SwiftPM that appears to have been introduced in swiftlang/swift-package-manager#8049.

Works around swiftlang/swift-package-manager#8111 until swiftlang/swift-package-manager#8112 is in the build.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Work around Windows build failure due to SwiftPM regression.
b03288b 
Works around a link-time bug in SwiftPM that appears to have been introduced in
swiftlang/swift-package-manager#8049.
@grynspan grynspan added bug 🪲 Something isn't working windows 🪟 Windows support workaround Workaround for an issue in another component (may need to revert later) build 🧱 Affects the project's build configuration or process labels Nov 11, 2024
@grynspan grynspan self-assigned this Nov 11, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan requested a review from dschaefer2 November 11, 2024 15:38
@grynspan grynspan merged commit cc2c42e into main Nov 11, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/windows-build-failure branch November 11, 2024 15:55
@grynspan grynspan added this to the Swift 6.x milestone Dec 5, 2024
@stmontgomery stmontgomery mentioned this pull request Dec 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dschaefer2 dschaefer2 dschaefer2 approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process windows 🪟 Windows support workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @dschaefer2