Fix multiline comments not rendering correctly at CLI. #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug where a multi-line comment or message written to `stderr` would only have its first line in grey and would not write atomically, resulting in odd/incorrect output. All messages generated by a test event are now written to `stderr` atomically. (I thought we had an issue tracking this somewhere but now I can't find it.)
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
approved these changes
Dec 10, 2024
plemarquand
approved these changes
Dec 10, 2024
grynspan
added a commit
that referenced
this pull request
Dec 10, 2024
This PR fixes a bug where a multi-line comment or message written to `stderr` would only have its first line in grey and would not write atomically, resulting in odd/incorrect output. All messages generated by a test event are now written to `stderr` atomically. Resolves rdar://134519515. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Dec 10, 2024
- **Explanation**: Refactor multi-line comment formatting in CLI and JSON output so they correctly render. - **Scope**: CLI (`swift test`), VS Code plugin - **Issues**: rdar://134519515 - **Original PRs**: #850 - **Risk**: Low (no obvious risk) - **Testing**: No additional testing needed. Verified output manually in CLI and VS Code. - **Reviewers**: @briancroom @stmontgomery @plemarquand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a multi-line comment or message written to
stderrwould only have its first line in grey and would not write atomically, resulting in odd/incorrect output. All messages generated by a test event are now written tostderratomically.Resolves rdar://134519515.
Checklist: