-
Notifications
You must be signed in to change notification settings - Fork 131
Update swift-system to increase Linux compatibility #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vlm
commented
Oct 21, 2022
•
edited
Loading
edited
- 1.2.1 contains CSystem import fixes that are required for Linux compatibility.
@swift-ci please test |
Please test windows before merging this, and include SPM and LSP tests too. |
iirc to get this update into the toolchain, we need to update a few more spots, correct? cc @shahmishal |
@tomerd yes, update-checkout needs to be updated and we need to synchronise with compnerd/swift-build |
Looks like there's a conflict with one of the other dependencies in the toolchain:
I guess because we have multiple roots, we don't get a clear error? BTW, to test Windows and SourceKit-LSP, you can open a PR on the Swift repo and use cross repository testing with this PR. |
@vlm do you want to push this forward? @MaxDesiatov is updating argument parser so he can share notes on all the places that need to be changed |
So we can have one set of update-checkout changes Requires swiftlang/swift-tools-support-core#358
This comment was marked as outdated.
This comment was marked as outdated.
@swift-ci please test |
@yim-lee i don't believe this repo supports cross repo testing, so it would need to be tested via the SwiftPM PR |
@tomerd it seems to work 👍 |