Skip to content

Update swift-system to increase Linux compatibility #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vlm
Copy link
Contributor

@vlm vlm commented Oct 21, 2022

  • 1.2.1 contains CSystem import fixes that are required for Linux compatibility.

@neonichu
Copy link
Contributor

@swift-ci please test

@compnerd
Copy link
Member

Please test windows before merging this, and include SPM and LSP tests too.

@tomerd
Copy link
Contributor

tomerd commented Oct 24, 2022

iirc to get this update into the toolchain, we need to update a few more spots, correct? cc @shahmishal

@compnerd
Copy link
Member

@tomerd yes, update-checkout needs to be updated and we need to synchronise with compnerd/swift-build

@neonichu
Copy link
Contributor

Looks like there's a conflict with one of the other dependencies in the toolchain:

+ swift test --parallel --enable-test-discovery --multiroot-data-file Utilities/ci.xcworkspace --test-product swift-tools-support-corePackageTests
warning: --multiroot-data-file is an *unsupported* option which can be removed at any time; do not rely on it
warning: '--enable-test-discovery' option is deprecated; tests are automatically discovered on all platforms
Fetching https://github.com/apple/swift-syntax.git
Fetched https://github.com/apple/swift-syntax.git (1.16s)
error: Dependencies could not be resolved because root depends on 'swift-system' 1.1.1..<1.2.0 and root depends on 'swift-system' 1.2.1..<1.3.0.

I guess because we have multiple roots, we don't get a clear error?

BTW, to test Windows and SourceKit-LSP, you can open a PR on the Swift repo and use cross repository testing with this PR.

@tomerd
Copy link
Contributor

tomerd commented Nov 14, 2022

@vlm do you want to push this forward? @MaxDesiatov is updating argument parser so he can share notes on all the places that need to be changed

yim-lee added a commit to dnadoba/swift-package-manager that referenced this pull request May 16, 2023
So we can have one set of update-checkout changes

Requires swiftlang/swift-tools-support-core#358
@yim-lee

This comment was marked as outdated.

@yim-lee
Copy link
Contributor

yim-lee commented May 16, 2023

swiftlang/swift#65938

@swift-ci please test

@yim-lee
Copy link
Contributor

yim-lee commented May 16, 2023

@tomerd
Copy link
Contributor

tomerd commented May 16, 2023

@yim-lee i don't believe this repo supports cross repo testing, so it would need to be tested via the SwiftPM PR

@yim-lee
Copy link
Contributor

yim-lee commented May 16, 2023

@tomerd it seems to work 👍

@yim-lee
Copy link
Contributor

yim-lee commented May 24, 2023

@compnerd
Copy link
Member

@neonichu I think that we might be able to close this after #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants